Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary parenthesis #2412

Merged
merged 6 commits into from
May 24, 2024
Merged

remove unnecessary parenthesis #2412

merged 6 commits into from
May 24, 2024

Conversation

sdelamo
Copy link
Collaborator

@sdelamo sdelamo commented May 21, 2024

Close: #2409

timyates
timyates approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is an unrelated front end failure that also happens on develop 🤔

@timyates timyates merged commit 4188a1b into develop May 24, 2024
1 check passed
@timyates
Copy link
Collaborator

Merged this before it got too hard to merge 😉

@timyates timyates deleted the feature-2409/remove-parenthesis branch May 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

@mjperry91 mjperry91 mjperry91 approved these changes

@mkimberlin mkimberlin Awaiting requested review from mkimberlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No need to specify parenthesis for annotations with no member value
3 participants
@sdelamo @timyates @mjperry91