(Backend) - Update Google Dependencies to Address Vulnerabilities and General Tech Debt #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest minor of postgres-socket-factory pulls the latest major client-api, so I updated them all to latest
mjperry91
approved these changes
May 21, 2024
mkimberlin
reviewed
May 24, 2024
| @@ -16,7 +16,7 @@ | |||
| @Singleton | |||
| public class GoogleDriveAccessor { | |||
|
|
|||
| private static final JsonFactory JSON_FACTORY = JacksonFactory.getDefaultInstance(); | |||
| private static final JsonFactory JSON_FACTORY = GsonFactory.getDefaultInstance(); | |||
There was a problem hiding this comment.
Any particular driver for this change? Just curious.
There was a problem hiding this comment.
They removed JacksonFactory in favor of GsonFactory
mkimberlin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original plan was to perform a minor upgrade of the Google dependencies, however the latest
postgres-socket-factorypulls in a transitive major update to v2 of thegoogle-api-clientSo I went for it and grabbed the latest major version of all Google dependencies.
Also updated:
Some Google classes have changed package, but I don't believe these are persisted (internal use only), so I think this is ok