fix: Request is marked nullable, so should be checked #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the PermissionSecurityRule, the request object is annotated as Nullable, but we weren't testing for null. This PR checks for null first of all. I refactored the method into a optional flow which I hope is easier to read. And then fixed the tests (we no longer call hasAnnotation as findAnnotation returns an optional, so provides enough info to continue)
mkimberlin
approved these changes
Jun 18, 2024
vhscom
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PermissionSecurityRule, the request object is annotated as Nullable, but we weren't testing for null.
This PR checks for null first of all.
I refactored the method into a optional flow which I hope is easier to read.
And then fixed the tests (we no longer call hasAnnotation as findAnnotation returns an optional, so provides enough info to continue)