-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Role based External Documents #2521
Merged
mkimberlin
merged 22 commits into
develop
from
feature-1656/backend-for-external-documents
Jul 1, 2024
Merged
Add Role based External Documents #2521
mkimberlin
merged 22 commits into
develop
from
feature-1656/backend-for-external-documents
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhscom
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Fallback to the old documents if there are none found (for now) Not sure why I cannot style anything 🤔
…re-1656/firstpass-front-end-for-external-documents
…front-end-for-external-documents Fetch documents from the server in the UI
mkimberlin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the backend and simple readonly front-end required for #1656
the front end was done in #2522 and merged in to here
Schema
DTO format
DocumentCreateDTO
Note
name
andurl
must be unique across all documents, anddescription
is optionalDocumentResponseDTO
Note
description
may benull
Endpoints
GET /services/document
-- List all documents.DocumentResponseDTO
ordered by nameGET /services/document/{role_id}
-- List documents assigned to a roleDocumentResponseDTO
assigned to the given role_id, ordered by the display_order in the databasePOST /services/document
-- Create a documentCAN_ADMINISTER_DOCUMENTATION
requiredDocumentCreateDTO
as the bodyPUT /services/document/{documentId}
-- Update a documentCAN_ADMINISTER_DOCUMENTATION
requiredDocumentCreateDTO
as the bodyDELETE /services/document/{documentId}
-- Delete a documentCAN_ADMINISTER_DOCUMENTATION
requiredPOST /services/document/{role_id}
-- Set the list of documents for a roleCAN_ADMINISTER_DOCUMENTATION
requiredUUID
strings as the body (these are document ids)DocumentResponseDTO
assigned to the given role_id, ordered by the display_order in the database