Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Are you interested in making one of the internal initializers public? #9

Closed
RLovelett opened this issue Oct 19, 2017 · 1 comment

Comments

@RLovelett
Copy link

RLovelett commented Oct 19, 2017

I was wondering what stomach you might have for making one of the initializers that is currently marked as internal as public. I was thinking of documenting the initializer and changing the access scope to public and submitting a PR. I wanted to check to see if that was something you were willing to entertain before I spent the time.

I'm writing a DER/BER encoder/decoder and your BigInt implementation is a great solution for storing and displaying arbitrary length integers. In fact, for the most part your init I linked above is almost exactly what is encoded in the format. If I parse and send it to that init I get the integer I was expecting.

@objecthub
Copy link
Owner

I didn't see a use case for the constructor so I declared it internal. Since the constructor is totally safe to use and does the required normalisations, all what's needed is some documentation to make it public. Just send me a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants