You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering what stomach you might have for making one of the initializers that is currently marked as internal as public. I was thinking of documenting the initializer and changing the access scope to public and submitting a PR. I wanted to check to see if that was something you were willing to entertain before I spent the time.
I'm writing a DER/BER encoder/decoder and your BigInt implementation is a great solution for storing and displaying arbitrary length integers. In fact, for the most part your init I linked above is almost exactly what is encoded in the format. If I parse and send it to that init I get the integer I was expecting.
The text was updated successfully, but these errors were encountered:
I didn't see a use case for the constructor so I declared it internal. Since the constructor is totally safe to use and does the required normalisations, all what's needed is some documentation to make it public. Just send me a PR.
I was wondering what stomach you might have for making one of the initializers that is currently marked as
internal
aspublic
. I was thinking of documenting the initializer and changing the access scope topublic
and submitting a PR. I wanted to check to see if that was something you were willing to entertain before I spent the time.I'm writing a DER/BER encoder/decoder and your
BigInt
implementation is a great solution for storing and displaying arbitrary length integers. In fact, for the most part yourinit
I linked above is almost exactly what is encoded in the format. If I parse and send it to thatinit
I get the integer I was expecting.The text was updated successfully, but these errors were encountered: