Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in test #136

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix bug in test #136

merged 1 commit into from
Sep 25, 2023

Conversation

c71n93
Copy link
Member

@c71n93 c71n93 commented Sep 25, 2023

Due to this bug the Resolver test was always passed. The expected test files were always compared with themselves.

This PR fixes it.


PR-Codex overview

Detailed summary

  • The focus of this PR is to fix a file path issue in the ResolverBase.kt file.
  • The change involves replacing the file path string "out$sep" with "$eoOutTmp$sep" in the actual variable.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@c71n93
Copy link
Member Author

c71n93 commented Sep 25, 2023

@Graur could you check this one, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 25, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e329a2a into objectionary:master Sep 25, 2023
3 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 25, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants