feat(#1595): fix qulice suggestions

objectionary · Dec 20, 2022 · e922c66 · e922c66
1 parent 270b764
commit e922c66
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/ResolveMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/ResolveMojo.java
@@ -163,9 +163,9 @@ files, new Coordinates(dep)
      *
      * @return List of them
      * @todo #1595:30 Make method 'deps' testable. For now it's not possible to test
-     *   'ignoreTransitive=false' branch because it's hard to mock all required fields.
-     *   Maybe we should provide a chance to mock all dependencies related to maven or
-     *   even extract new classes.
+     *  'ignoreTransitive=false' branch because it's hard to mock all required fields.
+     *  Maybe we should provide a chance to mock all dependencies related to maven or
+     *  even extract new classes.
      */
     private Collection<Dependency> deps() {
         Iterable<Dependency> deps = new DcsDefault(
@@ -184,10 +184,9 @@ private Collection<Dependency> deps() {
                 dependency -> {
                     final Iterable<Dependency> transitives = new Filtered<>(
                         dep -> !ResolveMojo.eqTo(dep, dependency)
-                            && !dep.getScope().contains("test")
-                            && !dep.getScope().contains("provided")
+                            && ResolveMojo.isNotRuntimeRequired(dep)
                             && !("org.eolang".equals(dep.getGroupId())
-                                     && "eo-runtime".equals(dep.getArtifactId())),
+                            && "eo-runtime".equals(dep.getArtifactId())),
                         new DcsDepgraph(
                             this.project,
                             this.session,
@@ -227,6 +226,15 @@ private Collection<Dependency> deps() {
             .collect(Collectors.toList());
     }
 
+    /**
+     * Check if dependency is not needed at runtime.
+     * @param dep Maven dependency
+     * @return True if it's not needed at runtime
+     */
+    private static boolean isNotRuntimeRequired(final Dependency dep) {
+        return !dep.getScope().contains("test") && !dep.getScope().contains("provided");
+    }
+
     /**
      * Compare with NULL-safety.
      * @param left Left