Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit5 tests and their methods are 'public' -- it's unnecessary #1035

Closed
yegor256 opened this issue Aug 14, 2022 · 4 comments · Fixed by #1080
Closed

JUnit5 tests and their methods are 'public' -- it's unnecessary #1035

yegor256 opened this issue Aug 14, 2022 · 4 comments · Fixed by #1080
Assignees
Labels

Comments

@yegor256
Copy link
Member

yegor256 commented Aug 14, 2022

see https://stackoverflow.com/questions/55215949/why-junit-5-default-access-modifier-changed-to-package-private

let's make both classes and methods package-private. simply, remove the public.

@yegor256
Copy link
Member Author

@Graur pls, take care of this

@andreoss
Copy link
Member

@Graur
Copy link
Contributor

Graur commented Aug 15, 2022

@andreoss Indeed, thanks!
@yegor256 Should we use this rule as mandatory? And add JUnit5TestShouldBePackagePrivate to qulice pmd ruleset

@yegor256
Copy link
Member Author

@Graur @andreoss yes, definitely, let's add this to PMD and release new version of Qulice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants