Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array.eo:29-32: The method .empty is not nessesary. Make... #1087

Closed
0pdd opened this issue Aug 24, 2022 · 12 comments
Closed

array.eo:29-32: The method .empty is not nessesary. Make... #1087

0pdd opened this issue Aug 24, 2022 · 12 comments
Assignees

Comments

@0pdd
Copy link

0pdd commented Aug 24, 2022

The puzzle 1060-a52cb0e4 from #1060 has to be resolved:

# @todo #1060:30min The method .empty is not nessesary.
# Make the create of array possible just by using
# the object name, i.e `array > a` and remove this
# method.

The puzzle was created by @rultor on 24-Aug-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@yegor256
Copy link
Member

@Graur please, deal with this one

@Graur
Copy link
Contributor

Graur commented Aug 25, 2022

@levBagryansky please, help us here

@Graur Graur assigned levBagryansky and unassigned Graur Aug 25, 2022
@levBagryansky
Copy link
Member

@Graur it seems I can't do it yet, since array is a data object. I get these errors:

[INFO] Generated 2 .java file(s) from ./target/eo-test/06-transpile/org/eolang/as-phi-tests.xmir to ./target/generated-test-sources
[ERROR] [org.eolang.array-tests:188] Data objects can't be used directly: "org.eolang.array" (data-objects:23)
[ERROR] [org.eolang.array-tests:192] Data objects can't be used directly: "org.eolang.array" (data-objects:23)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

@Graur
Copy link
Contributor

Graur commented Aug 29, 2022

@levBagryansky So, this is the task. Maybe this will clear things up

@levBagryansky
Copy link
Member

levBagryansky commented Aug 30, 2022

@andreoss is it ok I cannot implement this @todo within only eo-files?
So must I change array from Data object to ordinary?

[INFO] Generated 2 .java file(s) from ./target/eo-test/06-transpile/org/eolang/as-phi-tests.xmir to ./target/generated-test-sources
[ERROR] [org.eolang.array-tests:188] Data objects can't be used directly: "org.eolang.array" (data-objects:23)
[ERROR] [org.eolang.array-tests:192] Data objects can't be used directly: "org.eolang.array" (data-objects:23)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

@andreoss
Copy link
Member

@levBagryansky do you have the latest master?

@levBagryansky
Copy link
Member

@andreoss yes

@Graur
Copy link
Contributor

Graur commented Aug 31, 2022

@levBagryansky don't you mind I give this ticket to @andreoss ?

@levBagryansky
Copy link
Member

@Graur I don't mind

@Graur
Copy link
Contributor

Graur commented Aug 31, 2022

@andreoss Can you help us here, please? The budget is 30 min

@Graur Graur assigned andreoss and unassigned levBagryansky Aug 31, 2022
andreoss added a commit to andreoss/eo that referenced this issue Sep 2, 2022
andreoss added a commit to andreoss/eo that referenced this issue Sep 2, 2022
andreoss added a commit to andreoss/eo that referenced this issue Sep 2, 2022
andreoss added a commit to andreoss/eo that referenced this issue Sep 2, 2022
@yegor256
Copy link
Member

@andreoss what's up with this?

@mximp mximp assigned mximp and unassigned andreoss Jan 20, 2023
@0pdd 0pdd closed this as completed Feb 20, 2023
@0pdd
Copy link
Author

0pdd commented Feb 20, 2023

The puzzle 1060-a52cb0e4 has disappeared from the source code, that's why I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants