Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptimizeMojo.java:278-280: move that method... #1443

Closed
0pdd opened this issue Nov 11, 2022 · 1 comment · Fixed by #1449
Closed

OptimizeMojo.java:278-280: move that method... #1443

0pdd opened this issue Nov 11, 2022 · 1 comment · Fixed by #1449
Assignees
@volodya-lombrozo
Labels
bug pdd

Comments

@0pdd
Copy link

0pdd commented Nov 11, 2022

The puzzle 1431-d4218ffb from #1431 has to be resolved:

eo/eo-maven-plugin/src/main/java/org/eolang/maven/OptimizeMojo.java

Lines 278 to 280 in 1d30f50

* @todo #1431:90min move that method implementation to a separate class under
* {@link org.eolang.maven.optimization} package. Probably, after implementation we will able
* to remove {@link org.eolang.maven.optimization.OptLambda}.

The puzzle was created by rultor on 11-Nov-22.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Nov 11, 2022
@rultor
Merge branch '__rultor'
1d30f50
This was referenced Nov 11, 2022
Closed
Closed
@volodya-lombrozo
Copy link
Member

@yegor256 assign to me, pls

volodya-lombrozo pushed a commit to volodya-lombrozo/eo that referenced this issue Nov 14, 2022
feat(objectionary#1443): move optimization to a separate package
91d5a73 
feat(objectionary#1443): create new OptTrain class

feat(objectionary#1443): make OptTrain work

feat(objectionary#1443): Optimization XML->XML

feat(objectionary#1443): Optimization FailOnError and FailOnWarning

feat(objectionary#1443): remove redundant classes

feat(objectionary#1443): finish with Optimization refactoing
@volodya-lombrozo volodya-lombrozo mentioned this issue Nov 14, 2022
Merged
volodya-lombrozo pushed a commit to volodya-lombrozo/eo that referenced this issue Nov 15, 2022
feat(objectionary#1443): remove untestable test case
7247cb4
volodya-lombrozo pushed a commit to volodya-lombrozo/eo that referenced this issue Nov 15, 2022
feat(objectionary#1443): remove untestable test case
5e9f3d9 
feat(objectionary#1443): remove unused imports
volodya-lombrozo pushed a commit to volodya-lombrozo/eo that referenced this issue Nov 15, 2022
feat(objectionary#1443): empty commit
86f3d1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
bug pdd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#1443): move optimization logic to separate classes volodya-lombrozo/eo
2 participants
@0pdd @volodya-lombrozo