Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseMojo.java:160-162: new FtCached(hash, cache, origin)... #1857

Closed
0pdd opened this issue Feb 28, 2023 · 0 comments · Fixed by #1860
Closed

ParseMojo.java:160-162: new FtCached(hash, cache, origin)... #1857

0pdd opened this issue Feb 28, 2023 · 0 comments · Fixed by #1860
Assignees
@volodya-lombrozo
Labels
bug pdd

Comments

@0pdd
Copy link

0pdd commented Feb 28, 2023

The puzzle 1226-84e22b8e from #1226 has to be resolved:

eo/eo-maven-plugin/src/main/java/org/eolang/maven/ParseMojo.java

Lines 160 to 162 in 703eee0

* @todo #1226:30min new FtCached(hash, cache, origin) should be replaced with a new constructor
* that uses the current eo-maven-plugin version - new FtCached(CacheVersion, cache, origin).
* This will allow us to invalidate the cache when the plugin version changes.

The puzzle was created by rultor on 28-Feb-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Feb 28, 2023
@rultor
Merge branch '__rultor'
703eee0
@0pdd 0pdd mentioned this issue Feb 28, 2023
Closed
@volodya-lombrozo volodya-lombrozo self-assigned this Feb 28, 2023
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Mar 2, 2023
@volodya-lombrozo
feat(objectionary#1857): Replace FtCached(hash, cache, origin) with F…
7ae2c89 
…tCached(CacheVersion, cache, origin)

fix(objectionary#1857): add test for uncacheable version

feat(objectionary#1857): add plugin version for cache

feat(objectionary#1857): fix old tests
@volodya-lombrozo volodya-lombrozo mentioned this issue Mar 2, 2023
Merged
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Mar 6, 2023
@volodya-lombrozo
feat(objectionary#1857): add more informative JavaDoc for plugin para…
e3272e6 
…meter
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Mar 6, 2023
@volodya-lombrozo
feat(objectionary#1857): Replace FtCached(hash, cache, origin) with F…
b70420d 
…tCached(CacheVersion, cache, origin)

fix(objectionary#1857): add test for uncacheable version

feat(objectionary#1857): add plugin version for cache

feat(objectionary#1857): fix old tests
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Mar 6, 2023
@volodya-lombrozo
feat(objectionary#1857): add more informative JavaDoc for plugin para…
410d30c 
…meter
0pdd referenced this issue Mar 7, 2023
@rultor
Merge branch '__rultor'
015d585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
bug pdd
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#1857): Use FtCached with correct CacheVersion volodya-lombrozo/eo
2 participants
@0pdd @volodya-lombrozo