Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to-java.xsl:26-30: Change the behaviour of conversions... #2096

Closed
0pdd opened this issue May 26, 2023 · 7 comments
Closed

to-java.xsl:26-30: Change the behaviour of conversions... #2096

0pdd opened this issue May 26, 2023 · 7 comments
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented May 26, 2023

The puzzle 1890-dcbd8a31 from #1890 has to be resolved:

@todo #1890:30m Change the behaviour of conversions for names
with underscore. Currently, the conversion is done by replacing
underscore with doubled underscore. We need to find more elegant
solution. For example, we can use camel case for names with underscore.
For example, we can convert `foo_bar` to `fooBar`. Or something else.

The puzzle was created by rultor on 26-May-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@mximp
Copy link
Contributor

mximp commented May 29, 2023

@volodya-lombrozo Are there any technical issue with using double underscore?

@mximp mximp added this to the M3 milestone May 29, 2023
@volodya-lombrozo
Copy link
Member

@mximp I don't see any technical issue since I can't find any disabled tests related to the problem

@Graur or I'm missing something?

@Graur
Copy link
Contributor

Graur commented May 30, 2023

@mximp @volodya-lombrozo Technical issue: #1890.
This puzzle was created because our current solution is weak. And it has a counter example. E.g. absolutely valid object named a--b and object named a_b will have the same name at compile time: EOa__b.

@volodya-lombrozo
Copy link
Member

@Graur Do we have the test for that case?

@Graur
Copy link
Contributor

Graur commented May 31, 2023

@volodya-lombrozo We don't. I will add it ASAP

@Graur Graur modified the milestones: M3, Urgent Aug 11, 2023
@Graur Graur self-assigned this Aug 11, 2023
@Graur
Copy link
Contributor

Graur commented Aug 14, 2023

Let's close

@Graur Graur closed this as completed Aug 14, 2023
@volodya-lombrozo
Copy link
Member

@Graur Maybe we should remove the puzzle description from the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants