Skip to content

Commit

Permalink
feat(#2381): added todo to rename objects
Browse files Browse the repository at this point in the history
  • Loading branch information
@maxonfjvipon
maxonfjvipon committed Aug 14, 2023
1 parent 49b363d commit d4f0a1e
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions eo-maven-plugin/src/main/java/org/eolang/maven/name/OnDefault.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
* Object name with default hash.
*
* @since 0.29.6
* @todo #2381:30min Rename OnDefault and OnVersioned objects.
* Both seems misleading: OnVersioned replaces tag in given object with hash,
* OnDefault checks if given object contains version and if not - put the
* default one.
* It seems the names of the objects don't match with their behaviour.
* Suggestion: OnVersioned -> OnReplaced, OnDefault -> OnVersioned
*/
public final class OnDefault implements ObjectName {

Expand Down

3 comments on commit d4f0a1e

@0pdd
Copy link

@0pdd 0pdd commented on d4f0a1e Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 1890-dcbd8a31 disappeared from eo-maven-plugin/src/main/resources/org/eolang/maven/pre/to-java.xsl), that's why I closed #2096. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on d4f0a1e Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 2376-3d36c5d7 disappeared from eo-maven-plugin/src/main/java/org/eolang/maven/name/OnVersioned.java), that's why I closed #2381. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link

@0pdd 0pdd commented on d4f0a1e Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 2381-b6d409bc discovered in eo-maven-plugin/src/main/java/org/eolang/maven/name/OnDefault.java) and submitted as #2389. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.