Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscoverMojo.java:128-134: Simplify xpath. Current... #2259

Closed
0pdd opened this issue Jul 14, 2023 · 5 comments · Fixed by #2296
Closed

DiscoverMojo.java:128-134: Simplify xpath. Current... #2259

0pdd opened this issue Jul 14, 2023 · 5 comments · Fixed by #2296
Assignees

Comments

@0pdd
Copy link

0pdd commented Jul 14, 2023

The puzzle 1602-59e4ff34 from #1602 has to be resolved:

* @todo #1602:30min Simplify xpath. Current implementation for building
* xpath with and without versions is quite ugly. For some reason
* if we try to take `/concat(@base,'|',@ver)` and there are object without
* attribute `ver` - xpath returns nothing. So we need to take `/@base`
* from objects where attribute `ver` is not present in both cases and
* then if flag `withVersions` is `true` - take `concat(@base,'|',@ver)`
* from objects attribute `ver` is present.

The puzzle was created by rultor on 14-Jul-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@volodya-lombrozo
Copy link
Member

Related discussion: #2228 (comment)

@0pdd
Copy link
Author

0pdd commented Jul 18, 2023

@0pdd the puzzle #2266 is still not solved.

@volodya-lombrozo
Copy link
Member

Blocked by jcabi/jcabi-xml#211

@0pdd
Copy link
Author

0pdd commented Jul 19, 2023

@0pdd the puzzle #2278 is still not solved; solved: #2266.

@0pdd
Copy link
Author

0pdd commented Jul 21, 2023

@0pdd all 2 puzzles are solved here: #2266, #2278.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants