Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProbeMojoTest.java:70-74: Refactor firstEntity method.... #2331

Closed
0pdd opened this issue Jul 28, 2023 · 2 comments · Fixed by #2388
Closed

ProbeMojoTest.java:70-74: Refactor firstEntity method.... #2331

0pdd opened this issue Jul 28, 2023 · 2 comments · Fixed by #2388
Assignees
@volodya-lombrozo
Labels
bug pdd
Milestone
Urgent

Comments

@0pdd
Copy link

0pdd commented Jul 28, 2023

The puzzle 2302-4b0bd16e from #2302 has to be resolved:

eo/eo-maven-plugin/src/test/java/org/eolang/maven/ProbeMojoTest.java

Lines 70 to 74 in 032cd80

* @todo #2302:30min Refactor firstEntity method. The "first entity of the
* foreign tojos" looks strange. It looks like we are tying to scan an
* intermediate state which we are trying to read in the middle of the process.
* It lead to a fragile implementation. Could we check the result somehow else?
* Or to skip that check at all?

The puzzle was created by rultor on 28-Jul-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Jul 28, 2023
@rultor
Merge branch '__rultor'
032cd80
This was referenced Jul 28, 2023
Open
Closed
@Graur Graur added this to the Urgent milestone Aug 14, 2023
@volodya-lombrozo volodya-lombrozo self-assigned this Aug 14, 2023
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Aug 14, 2023
@volodya-lombrozo
feat(objectionary#2331): Remove firstEntity method and add utility me…
02bf288 
…thods to FakeMaven and ForeignTojos
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Aug 14, 2023
@volodya-lombrozo
feat(objectionary#2331): Fix all qulice suggestions
3d9b174
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Aug 14, 2023
@volodya-lombrozo
feat(objectionary#2331): Remove the puzzle for the objectionary#2331 …
ac82872 
…issue
@volodya-lombrozo volodya-lombrozo mentioned this issue Aug 14, 2023
Merged
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Aug 14, 2023
@volodya-lombrozo
feat(objectionary#2331): Add new puzzle
3b1443a
volodya-lombrozo added a commit to volodya-lombrozo/eo that referenced this issue Aug 14, 2023
@volodya-lombrozo
feat(objectionary#2331): Add new puzzle
e190328
0pdd referenced this issue Aug 15, 2023
@rultor
Merge branch '__rultor'
6791cb5
@0pdd 0pdd mentioned this issue Aug 15, 2023
Closed
@0pdd
Copy link
Author

0pdd commented Aug 15, 2023

@0pdd the puzzle #2392 is still not solved.

@0pdd
Copy link
Author

0pdd commented Aug 16, 2023

@0pdd the only puzzle #2392 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
bug pdd
Projects
None yet
Milestone
Urgent
Development

Successfully merging a pull request may close this issue.

refactor(#2331): Remove firstEntry method from ProbeMojoTest volodya-lombrozo/eo
3 participants
@0pdd @Graur @volodya-lombrozo