Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerifyMojo doesn't log warnings, but simply ignores them #2714

Closed
yegor256 opened this issue Dec 22, 2023 · 3 comments · Fixed by #2870
Closed

VerifyMojo doesn't log warnings, but simply ignores them #2714

yegor256 opened this issue Dec 22, 2023 · 3 comments · Fixed by #2870
Assignees
@levBagryansky
Labels
bug
Milestone
Important

Comments

@yegor256
Copy link
Member

Now, VerifyMojo, if failOnWarning is false does nothing with the warnings. However, it should log them through Logger.warn. I think, it should log everything (errors, critical, warnings), and only then either fail the build or not.
@yegor256 yegor256 added the bug label Dec 22, 2023
@yegor256
Copy link
Member Author

@maxonfjvipon please, help

@maxonfjvipon
Copy link
Member

@levBagryansky can you take it?

@maxonfjvipon maxonfjvipon added this to the Important milestone Feb 2, 2024
@levBagryansky
Copy link
Member

@maxonfjvipon sure

levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 7, 2024
@levBagryansky
objectionary#2714: loggingOfErrors
5ba573f
levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 7, 2024
@levBagryansky
objectionary#2714: formatting
78391b8
levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 7, 2024
@levBagryansky
objectionary#2714: restart
f5064b0
levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 7, 2024
@levBagryansky
objectionary#2714: restart
11cb9a3
@levBagryansky levBagryansky mentioned this issue Feb 7, 2024
Merged
levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 7, 2024
@levBagryansky
objectionary#2714: this::logErrors
99e3d8c
levBagryansky added a commit to levBagryansky/eo that referenced this issue Feb 8, 2024
@levBagryansky
objectionary#2714: added switching by severity
5751386
yegor256 added a commit that referenced this issue Feb 13, 2024
@yegor256
Merge pull request #2870 from levBagryansky/2714_log-warnings
1da912b 
#2714: loggingOfErrors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levBagryansky levBagryansky

Labels
bug
Projects
None yet
Milestone
Important
Development

Successfully merging a pull request may close this issue.

#2714: loggingOfErrors levBagryansky/eo
3 participants
@yegor256 @levBagryansky @maxonfjvipon