Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XeEoListener.java:52-58: Change severity on comments... #2841

Closed
0pdd opened this issue Feb 2, 2024 · 1 comment · Fixed by #2858
Closed

XeEoListener.java:52-58: Change severity on comments... #2841

0pdd opened this issue Feb 2, 2024 · 1 comment · Fixed by #2858
Milestone

Comments

@0pdd
Copy link

0pdd commented Feb 2, 2024

The puzzle 2835-fdd45ac6 from #2835 has to be resolved:

* @todo #2835:30min Change severity on comments validation. Current severity on comments validation
* is "warning". We need to change it to "error" to prevent users from ignoring this type of error.
* But there's a pitfall - there are so many little toy abstract objects in EO tests which we don't
* really want to document. That's why we should not validate comments if there's "+junit" meta in
* program. Also "eo-runtime" does not fail on warning now because it's not well documented. After
* eo-runtime is documented well - we need to turn on "failOnWarning" trigger in pom.xml inside
* "eo-runtime.

The puzzle was created by maxonfjvipon on 01-Feb-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Author

0pdd commented Feb 5, 2024

@0pdd the puzzle #2860 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants