Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to UnphiMojo that adds +tests meta to XMIR #2909

Closed
maxonfjvipon opened this issue Mar 1, 2024 · 9 comments · Fixed by #2913
Closed

Add flag to UnphiMojo that adds +tests meta to XMIR #2909

maxonfjvipon opened this issue Mar 1, 2024 · 9 comments · Fixed by #2913

Comments

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Mar 1, 2024

Here we get the situation where +tests meta is not transfered to XMIR while unphi stage.
The solution is to add flag to UnphiMojo that adds such meta.
Then we also need to add such flag to eoc

@maxonfjvipon maxonfjvipon changed the title Add flag to UnphiMojol Add flag to UnphiMojo that adds +tests meta to XMIR Mar 1, 2024
@yegor256
Copy link
Member

yegor256 commented Mar 1, 2024

@maxonfjvipon maybe we can make it possible to add different metas (like +package, etc):

mvn eo:unphi "-Deo.unphiMeta=+tests" "-Deo.unphiMeta=+package" "-Deo.unphiMeta=+architect yegor"

@maxonfjvipon
Copy link
Member Author

maxonfjvipon commented Mar 1, 2024

@yegor256 +package is converted to phi as an object with lambda

@yegor256
Copy link
Member

yegor256 commented Mar 1, 2024

@maxonfjvipon let's prohibit the usage of +package, but others may be necessary to use in the future. It would be great to make it possible now.

@maxonfjvipon
Copy link
Member Author

@yegor256 let's make a new release with tag 0.35.6

@yegor256
Copy link
Member

yegor256 commented Mar 5, 2024

@rultor release, tag is 0.35.6

@rultor
Copy link
Contributor

rultor commented Mar 5, 2024

@rultor release, tag is 0.35.6

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Mar 5, 2024

@rultor release, tag is 0.35.6

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 17min)

@maxonfjvipon
Copy link
Member Author

@yegor256 did it get to maven central?

@yegor256
Copy link
Member

yegor256 commented Mar 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants