Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heap-tests.eo:30-33: Enable heap tests. The tests were... #3002

Closed
0pdd opened this issue Mar 27, 2024 · 4 comments · Fixed by #3051
Closed

heap-tests.eo:30-33: Enable heap tests. The tests were... #3002

0pdd opened this issue Mar 27, 2024 · 4 comments · Fixed by #3051

Comments

@0pdd
Copy link

0pdd commented Mar 27, 2024

The puzzle 2931-7e7e24f4 from #2931 has to be resolved:

# @todo #2931:30min Enable heap tests. The tests were disabled because they stopped working
# when \rho attribute became immutable. Need to find out what's going on and enable them.
# Tests: malloc-returns-different-pointers, malloc-return-error, increments-pointer,
# mallocs-do-not-overlap, write-and-read-without-error

The puzzle was created by maxonfjvipon on 27-Mar-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Copy link

@0pdd thanks for the report, but here some unclear moments:

  • The todo message mentions that the tests were disabled due to an issue with the '\rho' attribute becoming immutable. However, it doesn't provide any context or explanation about what the '\rho' attribute is or how it is related to the tests. To fix this, the author should provide a brief explanation or context about the '\rho' attribute.
  • The todo message lists several tests that need to be enabled but does not specify if there are any dependencies or order in which they should be enabled. This could lead to confusion for the contributor tasked with enabling the tests. The author should specify if there is a specific order or dependencies between the tests.
  • The todo message instructs to "find out what's going on" but does not provide any guidance or suggestions on how to go about investigating the issue. This could be challenging for a contributor who is not familiar with the codebase or the specific issue at hand. The author should provide more specific instructions or suggestions for investigating the issue.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@0pdd
Copy link
Author

0pdd commented Mar 27, 2024

@0pdd thanks for the report, but here some unclear moments: * The todo message mentions that the tes...

I see you're talking to me, but I can't reply since I'm not a chat bot.

maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
maxonfjvipon added a commit to maxonfjvipon/eo that referenced this issue Apr 5, 2024
@0pdd
Copy link
Author

0pdd commented Apr 5, 2024

@0pdd the puzzle #3055 is still not solved.

@0pdd
Copy link
Author

0pdd commented Apr 6, 2024

@0pdd the only puzzle #3055 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant