Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should get rid of vertex attribute #3037

Closed
maxonfjvipon opened this issue Apr 2, 2024 · 1 comment · Fixed by #3041
Closed

We should get rid of vertex attribute #3037

maxonfjvipon opened this issue Apr 2, 2024 · 1 comment · Fixed by #3041
Labels

Comments

@maxonfjvipon
Copy link
Member

Unique vertex attribute is some kind of magic which gives unique number to every when it's formed or copied. Actually vertex is useful when we want compare objects between each other. But it's not quite right to compare object in this way. It's not right to compare objects at all.
Also it's not really possible to write a EO code where we can find the same vertexes in two objects because every object dispatch makes a copy of dispatched objects.

x.y.< # 1
x.y.< # 2

The y objects above are different. We can only compare top-level objects like int, string, memory it does not really make sense
So, objects should not have attribute vertex at all

Copy link

github-actions bot commented Apr 2, 2024

@maxonfjvipon thanks for the report, but here some unclear moments:

  • The bug report lacks a clear and concise summary of the problem. It should start with a one-line summary that briefly describes the issue.
  • The report is missing crucial details such as the system version, the steps to reproduce the bug, and the expected versus actual results. Including these details can help developers understand and reproduce the issue quickly.
  • The bug report contains opinions ("It's not right to compare objects at all") instead of sticking to factual information. It's important for the author to remain objective and focus on describing the observed problem.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant