624 bypass caching #1023
624 bypass caching #1023
Conversation
|
@yegor256 please merge |
| * Fallback which can swap primary/secondary repos. | ||
| * @since 1.0 | ||
| */ | ||
| public static final class FallbackSwapOy implements Objectionary { |
There was a problem hiding this comment.
@mximp I think it would be better to make it an outside class, like all others that start with Oy
There was a problem hiding this comment.
@yegor256 The reason I made it nested is that it's quite specific implementation of Oy tightly bound to PullMojo. For now there is only one use case for this - Oy build strategy for PullMojo.
Wrapping this logic into class simplifies testing of it and usage, but I don't see a reason to make it standalone.
There was a problem hiding this comment.
@mximp all other Oy classes are only used by PullMojo. This one is no different.
|
@mximp it's hard to understand the logic, since the puzzle was not about swapping, but about cleaning the cache. would be nice to have some explanation of the idea in the Javadoc of this new Oy* class |
|
@yegor256 I've added some docs. Please check if the idea is more clear now. |
eo-maven-plugin/README.md
Outdated
| During compilation the plugin will download required objects from | ||
| [Objectionary home](https://github.com/objectionary/home) and cache them. | ||
|
|
||
| Caching may be |
There was a problem hiding this comment.
@mximp this doesn't seem accurate. This option (full name is --update-snapshots) forces Maven to download latest versions of snapshot dependencies from Internet and cache in ~/.m2. Thus, caching is not disable, but its update is enforced. In our case, we should do the same: keep the cache in ~/.eo but make sure that even if an .eo file exists locally, we still download it and cache.
There was a problem hiding this comment.
@yegor256 True - corrected
|
@mximp see above |
|
@yegor256 please check now.
|
|
@yegor256 reminder, please check |
|
@rultor merge |
#624