Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1230 introduce multithreading for parsing #1335

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

mximp
Copy link
Contributor

@mximp mximp commented Oct 14, 2022

#1230 Introduced multithreading for parsing.

Fixed thread pool is used as executor.
Synchronized Tojo implementation is provided to make Foreign catalog file access safe.

Since parsing takes not that much time overall performance gain for Fibonacci app with 4 threads constitutes 2-3 seconds.

@mximp
Copy link
Contributor Author

mximp commented Oct 14, 2022

@yegor256 please review

@mximp mximp requested a review from yegor256 October 14, 2022 07:20
@yegor256
Copy link
Member

@mximp maybe it's better to use this: yegor256/tojos#16

@mximp
Copy link
Contributor Author

mximp commented Oct 14, 2022

@mximp maybe it's better to use this: yegor256/tojos#16

@yegor256 Definitely better. Since it's not implemented yet I couldn't find it and implemented quick version on my own.
Can we create a separate task for replacement onece it's ready?

@yegor256
Copy link
Member

@mximp sure, but let's mark your class with todo, to not forget that we should replace it

@mximp
Copy link
Contributor Author

mximp commented Oct 14, 2022

@yegor256 done

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Oct 14, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2fd90f4 into objectionary:master Oct 14, 2022
@rultor
Copy link
Contributor

rultor commented Oct 14, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)

@mximp mximp deleted the 1230-parallel-parsing branch October 17, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants