new method `contains()` in `Objectionary` and `OyFake` #1567

MikhailLipanin · 2022-12-15T11:39:05Z

related #1395

UPD:

Moved test classes to their packages

MikhailLipanin · 2022-12-15T11:46:02Z

@volodya-lombrozo Can you pls have a look?

volodya-lombrozo

@MikhailLipanin I'm not sure that it's the best solution to add contains method for Objectionary. Is it the only way to check existence? Do we even need to check it?

eo-maven-plugin/src/test/java/org/eolang/maven/OyLambda.java

eo-maven-plugin/src/test/java/org/eolang/maven/OyFallbackTest.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyRemote.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyHome.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyFallbackSwap.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyFallback.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyEmpty.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyCaching.java

MikhailLipanin · 2022-12-15T12:28:39Z

@MikhailLipanin I'm not sure that it's the best solution to add contains method for Objectionary. Is it the only way to check existence? Do we even need to check it?

@volodya-lombrozo It will be used in ProbeMojo, which will check the existence of an object in Objectionary.
The second way to do this is by using get() method and catching an Exception if not found, but it is bad

MikhailLipanin · 2022-12-20T18:50:30Z

@volodya-lombrozo Can you pls see again?

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/Objectionary.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyCachingTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyCachingTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/OyFake.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyFallbackSwapTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyCachingTest.java

MikhailLipanin · 2022-12-21T10:10:30Z

@volodya-lombrozo, Note, that here in last commits, I haven't changed anything, except the "style" of code. Not a "logic".
But here is an error, that I mentioned in #1574 ---- this one with error in ParseMojo in Optional

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyEmpty.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyHome.java

eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/OyRemote.java

eo-maven-plugin/src/test/java/org/eolang/maven/OyFake.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyEmptyTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyLocalTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyFallbackTest.java

eo-maven-plugin/src/test/java/org/eolang/maven/OyFake.java

MikhailLipanin · 2022-12-22T14:04:54Z

@volodya-lombrozo I think, working github-actions now is a full Random. (see my last 2 commits)

volodya-lombrozo

@MikhailLipanin Looks good to me.
@yegor256 Can you merge please?

MikhailLipanin · 2022-12-23T16:54:54Z

@yegor256, can you merge pls?

yegor256 · 2022-12-25T04:54:45Z

@rultor merge

rultor · 2022-12-25T04:56:28Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-12-25T05:03:08Z

@rultor merge

@MikhailLipanin @yegor256 Oops, I failed. You can see the full log here (spent 7min)

    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoExecutionException: Coverage checks have not been met. See log for details.
    at org.jacoco.maven.CheckMojo.executeCheck (CheckMojo.java:194)
    at org.jacoco.maven.CheckMojo.executeMojo (CheckMojo.java:169)
    at org.jacoco.maven.AbstractJacocoMojo.execute (AbstractJacocoMojo.java:46)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:351)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:171)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:163)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:566)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :eo-runtime
\u001b[0m\u001b[0mcontainer ba4e71ce8fa68f1f0342e6839588c4fba2a1098b3fbbd32991ab8d5710a40f85 is dead
Sun 25 Dec 2022 06:03:02 AM CET

MikhailLipanin · 2022-12-25T06:58:25Z

@yegor256, It says that the problem is in eo-runtime, but I haven't changed it in this PR.
Now I have just set COVEREDRATIO values in eo-runtime/pom.xml and checks passed. Is this a valid solution? (Idk, can we change these values)

volodya-lombrozo · 2022-12-25T07:20:25Z

@MikhailLipanin It means that your code have not enough tests. In other words, code coverage become less with your PR.
In order to fix that - please, provide more tests in order to increase the code coverage.

volodya-lombrozo · 2022-12-25T10:01:54Z

@MikhailLipanin #1614

MikhailLipanin · 2022-12-26T10:35:15Z

@yegor256 Can you try to merge again pls?

yegor256 · 2022-12-26T10:37:15Z

@rultor merge

rultor · 2022-12-26T10:37:33Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

0pdd · 2022-12-26T10:44:52Z

@MikhailLipanin 2 puzzles #1622, #1623 are still not solved.

rultor · 2022-12-26T10:45:00Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)

0pdd · 2022-12-28T14:26:19Z

@MikhailLipanin the puzzle #1623 is still not solved; solved: #1622.

0pdd · 2022-12-28T14:48:10Z

@MikhailLipanin all 2 puzzles are solved here: #1622, #1623.

new method contains() in Objectionary and OyLambda

9e1e9e3

volodya-lombrozo suggested changes Dec 15, 2022

View reviewed changes

MikhailLipanin added 5 commits December 15, 2022 16:08

move test classes to their packages

bbac384

added tests

ca50dbe

Merge branch 'master' into OyLambda

9d7df66

Merge branch 'master' into OyLambda

af21619

Merge branch 'master' into OyLambda

9c7c194

MikhailLipanin requested a review from volodya-lombrozo December 20, 2022 18:50

volodya-lombrozo suggested changes Dec 20, 2022

View reviewed changes

empty commit

f2b364c

MikhailLipanin requested a review from volodya-lombrozo December 20, 2022 21:39

volodya-lombrozo suggested changes Dec 21, 2022

View reviewed changes

MikhailLipanin added 3 commits December 21, 2022 12:44

Matchers instead of Assertions + fix names in OyFake

45f7c34

PMD

d48a60a

PMD |B-(

80bb89b

volodya-lombrozo suggested changes Dec 21, 2022

View reviewed changes

eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java Outdated Show resolved Hide resolved

eo-maven-plugin/src/test/java/org/eolang/maven/objectionary/OyCachingTest.java Outdated Show resolved Hide resolved

MikhailLipanin added 2 commits December 21, 2022 13:28

default Ctor of OyFake

97c277a

use Home.save() instead of LengthOf().value()

c8822bc

MikhailLipanin changed the title ~~new method contains() in Objectionary and OyLambda~~ new method contains() in Objectionary and OyFake Dec 21, 2022

MikhailLipanin requested a review from volodya-lombrozo December 21, 2022 10:45

volodya-lombrozo suggested changes Dec 21, 2022

View reviewed changes

MikhailLipanin added 3 commits December 21, 2022 14:54

OyEmptyTest + refact

b7db058

Merge branch 'master' into OyLambda

31ba97e

refact

9a2f291

MikhailLipanin requested a review from volodya-lombrozo December 21, 2022 14:13

volodya-lombrozo suggested changes Dec 21, 2022

View reviewed changes

MikhailLipanin added 2 commits December 22, 2022 14:35

resolved review

e48fa98

added todo

fd98fbc

MikhailLipanin requested a review from volodya-lombrozo December 22, 2022 11:57

volodya-lombrozo suggested changes Dec 22, 2022

View reviewed changes

MikhailLipanin added 2 commits December 22, 2022 16:53

r3f4c70R

18ec61a

r3f4c70R (another try)

d594bc1

MikhailLipanin requested a review from volodya-lombrozo December 22, 2022 14:04

volodya-lombrozo approved these changes Dec 22, 2022

View reviewed changes

MikhailLipanin added 3 commits December 25, 2022 09:19

Merge branch 'master' into OyLambda

6d97849

set COVEREDRATIO to expected values

83a667f

set COVEREDRATIO to expected values (again)

2f437ad

Merge branch 'master' into OyLambda

36dc630

rultor merged commit 36dc630 into objectionary:master Dec 26, 2022

This was referenced Dec 26, 2022

OyRemote.java:41-44: In method contains() we catch an... #1622

Closed

OyFallbackTest.java:40-43: The "putsObjectToLocalCache"... #1623

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new method `contains()` in `Objectionary` and `OyFake` #1567

new method `contains()` in `Objectionary` and `OyFake` #1567

MikhailLipanin commented Dec 15, 2022 •

edited

Loading

MikhailLipanin commented Dec 15, 2022

volodya-lombrozo left a comment

MikhailLipanin commented Dec 15, 2022 •

edited

Loading

MikhailLipanin commented Dec 20, 2022

MikhailLipanin commented Dec 21, 2022 •

edited

Loading

MikhailLipanin commented Dec 22, 2022

volodya-lombrozo left a comment

MikhailLipanin commented Dec 23, 2022

yegor256 commented Dec 25, 2022

rultor commented Dec 25, 2022

rultor commented Dec 25, 2022

MikhailLipanin commented Dec 25, 2022

volodya-lombrozo commented Dec 25, 2022

volodya-lombrozo commented Dec 25, 2022

MikhailLipanin commented Dec 26, 2022

yegor256 commented Dec 26, 2022

rultor commented Dec 26, 2022

0pdd commented Dec 26, 2022

rultor commented Dec 26, 2022

0pdd commented Dec 28, 2022

0pdd commented Dec 28, 2022

new method contains() in Objectionary and OyFake #1567

new method contains() in Objectionary and OyFake #1567

Conversation

MikhailLipanin commented Dec 15, 2022 • edited Loading

MikhailLipanin commented Dec 15, 2022

volodya-lombrozo left a comment

Choose a reason for hiding this comment

MikhailLipanin commented Dec 15, 2022 • edited Loading

MikhailLipanin commented Dec 20, 2022

MikhailLipanin commented Dec 21, 2022 • edited Loading

MikhailLipanin commented Dec 22, 2022

volodya-lombrozo left a comment

Choose a reason for hiding this comment

MikhailLipanin commented Dec 23, 2022

yegor256 commented Dec 25, 2022

rultor commented Dec 25, 2022

rultor commented Dec 25, 2022

MikhailLipanin commented Dec 25, 2022

volodya-lombrozo commented Dec 25, 2022

volodya-lombrozo commented Dec 25, 2022

MikhailLipanin commented Dec 26, 2022

yegor256 commented Dec 26, 2022

rultor commented Dec 26, 2022

0pdd commented Dec 26, 2022

rultor commented Dec 26, 2022

0pdd commented Dec 28, 2022

0pdd commented Dec 28, 2022

new method `contains()` in `Objectionary` and `OyFake` #1567

new method `contains()` in `Objectionary` and `OyFake` #1567

MikhailLipanin commented Dec 15, 2022 •

edited

Loading

MikhailLipanin commented Dec 15, 2022 •

edited

Loading

MikhailLipanin commented Dec 21, 2022 •

edited

Loading