Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1574) Add concurrency test that shows the problem #1606

Merged
merged 3 commits into from
Dec 23, 2022
Merged

fix(#1574) Add concurrency test that shows the problem #1606

merged 3 commits into from
Dec 23, 2022

Conversation

volodya-lombrozo
Copy link
Member

Add concurrency test that shows the problem with concurrent reading/writing MonoTojo attributes. It's important enable test when yegor256/tojos#50 will be finished.

Test for #1574.

@volodya-lombrozo
Copy link
Member Author

@Graur Can you take a look, please?

Graur
Graur approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo Good one!

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 23, 2022

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 74d2092 into objectionary:master Dec 23, 2022
@rultor
Copy link
Contributor

rultor commented Dec 23, 2022

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graur Graur Graur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@volodya-lombrozo @yegor256 @rultor @Graur