2313 universe #2316
Merged
2313 universe #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Graur please take a look |
Graur
reviewed
Jul 25, 2023
There was a problem hiding this comment.
@levBagryansky Just to be sure: You take some part from EOrust class and put it to new Universe.class?
|
Yes, this functionality must be in other class. |
Graur
suggested changes
Jul 25, 2023
| * method relates to building a new eo object in rust insert. | ||
| * @checkstyle NonStaticMethodCheck (4 lines) | ||
| */ | ||
| public void put(final int vertex, final byte[] bytes) { |
There was a problem hiding this comment.
@levBagryansky You need to add something here to avoid style checkers failings
Graur
approved these changes
Jul 26, 2023
|
@yegor256 please check |
levBagryansky
force-pushed
the
2313_Universe
branch
from
ac2f55b
to
1493413
Compare
|
@yegor256 please check |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2313
PR-Codex overview
This PR focuses on introducing a new class called
Universein theeo-runtimemodule. It also includes changes to theNativeandEOrustclasses in theeo-maven-pluginmodule.Detailed summary
Universein theorg.eolangpackage.NativeTest.javaandNative.javato useorg.eolang.Universeinstead ofEOorg.EOeolang.EOrust.EOrustclass to useUniverseinstead ofEOrustas a parameter in the constructor and method.find,put,bind,copy, anddataizein theUniverseclass.