feat(#2375): fix the bug with AccessDenied exception in TranspileMojo #2380
Conversation
…xception on Windows OS
|
@Graur Could you take a look, please? |
There was a problem hiding this comment.
@volodya-lombrozo Seems like a good solution, but there are a couple of questions:
| * You can read more about the original problem in the following issue: | ||
| * - <a href="https://github.com/objectionary/eo/issues/2370">issue link</a> | ||
| * In other words, concurrent file deletions on the Windows OS can lead to an | ||
| * {@link java.nio.file.AccessDeniedException}, which could crash the build. |
There was a problem hiding this comment.
@volodya-lombrozo What do you think about creating a test case for such an issue? Maybe something like this https://www.yegor256.com/2018/03/27/how-to-test-thread-safety.html
There was a problem hiding this comment.
@Graur I'm already spend lots of time for that PR. Can we implement it the next PR? I have added a puzzle for it.
| this, | ||
| String.format("Can't delete file %s due to access denied", binary) | ||
| ); | ||
| synchronized (TranspileMojo.class) { |
There was a problem hiding this comment.
@volodya-lombrozo Did you think about Synchronized Decorators?
There was a problem hiding this comment.
@Graur What do you suggest to decorate? We don't have objects here. Or maybe I am missing something?
|
@Graur Could you have a look one more time, please? |
|
@Graur reminder |
|
@yegor256 Could you merge that changes, please? |
|
@rultor merge |
Fix the problem with
AccessDeniedExceptioninTranspileMojoCloses: #2375, #2370
PR-Codex overview
Detailed summary
java.nio.file.AccessDeniedExceptioninTranspileMojo.java.AccessDeniedExceptionwhen deleting files on Windows OS in thecleanUpClassesmethod.AccessDeniedExceptionin thecleanUpClassesmethod.cleanUpClassesmethod.