Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2327): remove the old hash attribute #2448

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Aug 28, 2023

Remove the old hash attribute from AssembleMojo and rename new hsh attribute to hash.

Closes: #2327


PR-Codex overview

Detailed summary

  • Renamed hsh parameter to hash in PullMojo and ProbeMojo classes.
  • Updated references to the renamed parameter in affected classes.
  • Removed unused hash parameter from pom.xml files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@Graur Could you take a look, please?

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo Good one!
@yegor256 Please have a look

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you merge that changes, please?

@volodya-lombrozo
Copy link
Member Author

@yegor256 Reminder

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5ad917a into objectionary:master Aug 29, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 29, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssembleMojo.java:92-96: Rename the parameter "hash"....
5 participants