Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2640): added snippet test for horizontal abstract syntax #2647

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Nov 29, 2023

Closes: #2640


PR-Codex overview

This PR focuses on adding test resources and snippets for simple-horizontal and complex-horizontal in the eo-maven-plugin.

Detailed summary

  • Added test resource for simple-horizontal.yaml
  • Added expected output for simple-horizontal.yaml
  • Added file path for simple-horizontal.eo
  • Added arguments for simple-horizontal.eo
  • Added eo code for simple-horizontal.eo
  • Added test resource for complex-horizontal.yaml
  • Added expected output for complex-horizontal.yaml
  • Added file path for complex-horizontal.eo
  • Added arguments for complex-horizontal.eo
  • Added eo code for complex-horizontal.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@maxonfjvipon it's too simple. Let's make it more complex, to see a number of named attributes on the same line:

+package simple
+alias org.eolang.io.stdout
+alias org.eolang.io.sprintf

[args...] (stdout msg > @) (sprintf "Hello, %s!" name > msg) ("Jeff" > name) > main

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look one more time

@yegor256
Copy link
Member

yegor256 commented Dec 1, 2023

@maxonfjvipon will merge after this one is fixed: #2660

@yegor256
Copy link
Member

@maxonfjvipon I'm ready to merge this one, but I'm sure it won't work because of varargs inside. Please, fix it.

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 22, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cbfb040 into objectionary:master Dec 22, 2023
12 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 22, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 21min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract objects in horizontal notation
3 participants