-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2866): fixed ξ
without dispatch + enabled phi pack
#2867
fix(#2866): fixed ξ
without dispatch + enabled phi pack
#2867
Conversation
@yegor256 please have a look |
@maxonfjvipon something is wrong here. We can't have an attribute |
@yegor256 so, when we meet |
@yegor256 or it won't exist in result phi expression? |
@maxonfjvipon there will be no |
ξ
without dispatch + enabled phi pack
@yegor256 please have a look |
@rultor merge |
@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 21min) |
@maxonfjvipon do you have any idea why this happens? Maybe we should increase memory for Java/Maven somehow? |
@yegor256 I increased stack size, let's try to merge again |
@rultor merge |
@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 10min) |
@maxonfjvipon thanks! |
Closes: #2866
Closes: #2864
PR-Codex overview
This PR focuses on improving the code diff in the eo-parser and eo-maven-plugin modules.
Detailed summary
Phi.g4
:(attr+ disp)
to be optional.pom.xml
:XePhiListener.java
:if (!this.attributes.empty())
is removed.as-phi.yaml
:phi
section.