Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2866): fixed ξ without dispatch + enabled phi pack #2867

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Feb 6, 2024

Closes: #2866
Closes: #2864


PR-Codex overview

This PR focuses on improving the code diff in the eo-parser and eo-maven-plugin modules.

Detailed summary

  • In Phi.g4:
    • Dispatch rule is modified to allow (attr+ disp) to be optional.
  • In pom.xml:
    • The stack size is increased from 128M to 256M.
  • In XePhiListener.java:
    • The condition if (!this.attributes.empty()) is removed.
  • In as-phi.yaml:
    • The skip flag is removed.
    • A comment is modified in the phi section.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Feb 8, 2024

@maxonfjvipon something is wrong here. We can't have an attribute \tau_i. Only \alpha_i, \varphi, etc. \tau is a letter that stands for attribute name, when we don't know the name of it, in formulas.

@maxonfjvipon
Copy link
Member Author

@yegor256 so, when we meet \tau in phi expression, how it should be converted to XMIR?

@maxonfjvipon
Copy link
Member Author

@yegor256 or it won't exist in result phi expression?

@yegor256
Copy link
Member

@maxonfjvipon there will be no \tau in a phi expression. It's illegal syntax.

@maxonfjvipon maxonfjvipon changed the title fix(#2866): enabled phi pack + renamed alpha with tau fix(#2866): enabled phi pack Feb 12, 2024
@maxonfjvipon maxonfjvipon changed the title fix(#2866): enabled phi pack fix(#2866): fixed ξ without dispatch + enabled phi pack Feb 12, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 21min)

@yegor256
Copy link
Member

@maxonfjvipon do you have any idea why this happens? Maybe we should increase memory for Java/Maven somehow?

@maxonfjvipon
Copy link
Member Author

@yegor256 I increased stack size, let's try to merge again

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 13, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 13, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 10min)

@yegor256 yegor256 merged commit e45d368 into objectionary:master Feb 13, 2024
15 checks passed
@yegor256
Copy link
Member

@maxonfjvipon thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as-phi.yaml:1-3: Enable phi test pack. Current test pack... Does Phi.g4 supports XI without dispatch?
3 participants