Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2930): simplified phi grammar + fixed bug with dispatch after formation #2936

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Mar 12, 2024

Ref: #2930

What's done:

  • Simplified Phi grammar
  • Resolved bug with dispatch after formation

PR-Codex overview

This PR refactors the parser and YAML files, updates object handling, and improves listener methods for better code organization.

Detailed summary

  • Refactored parser rules and listener methods
  • Updated object handling in parser
  • Added new object properties in listener methods

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 13, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a7e3a63 into objectionary:master Mar 13, 2024
16 checks passed
@rultor
Copy link
Contributor

rultor commented Mar 13, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 23min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants