Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3073): removed explicit copying from EO #3077

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Apr 10, 2024

Closes: #3073


PR-Codex overview

This PR removes copy references and updates syntax in various files. It also refactors naming conventions and simplifies XML attributes.

Detailed summary

  • Removed copy references in several files.
  • Updated syntax in XML files.
  • Refactored naming conventions.
  • Simplified XML attributes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Apr 10, 2024

@rultor merge

@maxonfjvipon @yegor256 Can't merge it. Some CI checks were failed. Apparently, the pull request is not ready to be merged since it has some problems. Please, fix them first.

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Apr 10, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 27ac1df into objectionary:master Apr 10, 2024
17 checks passed
@rultor
Copy link
Contributor

rultor commented Apr 10, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 18min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We can get rid of explicit object copying using '
3 participants