Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3188): improved PhiMojo #3191

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented May 17, 2024

What's done:

  1. Added ability to change phiOptimize flag
  2. PhiMojo fails on critical errors

Ref: #3188


PR-Codex overview

This PR updates the EO Maven plugin and PhiMojo test methods. It adds new test cases with and without optimizations, updates XSL files, and refactors class imports.

Detailed summary

  • Updated test methods in PhiMojoTest.java for optimizations.
  • Refactored class imports in PhiMojo.java.
  • Added new XSL file incorrect-inners.xsl.
  • Updated XMIR files in the test resources.

The following files were skipped due to too many changes: eo-maven-plugin/src/test/resources/org/eolang/maven/phi/xmir/OriginalException.xmir, eo-maven-plugin/src/test/resources/org/eolang/maven/phi/xmir/B.xmir

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon maxonfjvipon changed the title fix(#3188): improved PhiMojo fix(#3188): improved PhiMojo May 17, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented May 17, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e90ca8b into objectionary:master May 17, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented May 17, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 23min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants