fix(#293): added directories options for phi and unphi

objectionary · Jun 5, 2024 · 459ba7f · 459ba7f
1 parent 84a5321
commit 459ba7f
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 11 deletions.
diff --git a/src/commands/phi.js b/src/commands/phi.js
@@ -29,15 +29,15 @@ const {mvnw, flags} = require('../mvnw');
 
 /**
  * Command to convert .XMIR files into .PHI files.
- * @param {Hash} opts - All options
+ * @param {Object} opts - All options
  * @return {Promise} of assemble task
  */
 module.exports = function(opts) {
   gte('EO parser', opts.parser, '0.35.2');
   const target = path.resolve(opts.target);
-  const input = path.resolve(opts.target, '2-optimize');
+  const input = path.resolve(opts.target, opts.phiInput);
   console.debug('Reading .XMIR files from %s', rel(input));
-  const output = path.resolve(opts.target, 'phi');
+  const output = path.resolve(opts.target, opts.phiOutput);
   console.debug('Writing .PHI files to %s', rel(output));
   return mvnw(
     ['eo:xmir-to-phi']

diff --git a/src/commands/unphi.js b/src/commands/unphi.js
@@ -29,14 +29,14 @@ const {gte} = require('../demand');
 
 /**
  * Command to convert .PHI files into .XMIR files.
- * @param {Hash} opts - All options
+ * @param {Object} opts - All options
  * @return {Promise} of assemble task
  */
 module.exports = function(opts) {
   gte('EO parser', opts.parser, '0.35.2');
-  const input = path.resolve(opts.target, 'phi');
+  const input = path.resolve(opts.target, opts.unphiInput);
   console.debug('Reading .PHI files from %s', rel(input));
-  const output = path.resolve(opts.target, 'unphi');
+  const output = path.resolve(opts.target, opts.unphiOutput);
   console.debug('Writing .XMIR files to %s', rel(output));
   return mvnw(
     ['eo:phi-to-xmir']

diff --git a/src/eoc.js b/src/eoc.js
@@ -179,19 +179,23 @@ program.command('sodg')
 
 program.command('phi')
   .description('Generate PHI files from XMIR')
+  .option('--phi-input <dir>', 'Directory where XMIR files for translation to PHI are taken (relative to --target)', '2-optimize')
+  .option('--phi-output <dir>', 'Directory where translated PHI files are stored (relative to --target)', 'phi')
   .action((str, opts) => {
     clear(str);
     if (program.opts().alone == undefined) {
       register(program.opts())
         .then((r) => assemble(program.opts()))
-        .then((r) => phi(program.opts()));
+        .then((r) => phi({...program.opts(), ...str}));
     } else {
       phi(program.opts());
     }
   });
 
 program.command('unphi')
   .option('--tests', 'Add "+tests" meta to result XMIR files')
+  .option('--unphi-input <dir>', 'Directory where PHI files for translation to XMIR are taken (relative to --target)', 'phi')
+  .option('--unphi-output <dir>', 'Directory where translated XMIR files are stored (relative to --target)', 'unphi')
   .description('Generate XMIR files from PHI files')
   .action((str, opts) => {
     clear(str);

diff --git a/test/commands/test_phi.js b/test/commands/test_phi.js
@@ -38,14 +38,16 @@ describe('phi', function() {
       '--track-optimization-steps',
       '--parser=' + parserVersion,
       '--home-tag=' + homeTag,
+      '--phi-input=2-optimize',
+      '--phi-output=output',
       '-s', path.resolve(home, 'src'),
       '-t', path.resolve(home, 'target'),
     ]);
     assertFilesExist(
       stdout, home,
       [
         'target/2-optimize/phi.xmir',
-        'target/phi/phi.phi',
+        'target/output/phi.phi',
       ]
     );
     done();

diff --git a/test/commands/test_unphi.js b/test/commands/test_unphi.js
@@ -31,18 +31,20 @@ describe('unphi', function() {
   it('converts PHI files to XMIR files', function(done) {
     const home = path.resolve('temp/test-unphi/simple');
     fs.rmSync(home, {recursive: true, force: true});
-    fs.mkdirSync(path.resolve(home, 'target/phi'), {recursive: true});
-    fs.writeFileSync(path.resolve(home, 'target/phi/app.phi'), '{ ⟦ app ↦ ⟦ ⟧ ⟧ }');
+    fs.mkdirSync(path.resolve(home, 'target/input'), {recursive: true});
+    fs.writeFileSync(path.resolve(home, 'target/input/app.phi'), '{ ⟦ app ↦ ⟦ ⟧ ⟧ }');
     const stdout = runSync([
       'unphi',
       '--verbose',
       '--track-optimization-steps',
       '--tests',
       '--parser=' + parserVersion,
       '--home-tag=' + homeTag,
+      '--unphi-input=input',
+      '--unphi-output=output',
       '-t', path.resolve(home, 'target'),
     ]);
-    const unphied = 'target/unphi/app.xmir';
+    const unphied = 'target/output/app.xmir';
     assertFilesExist(
       stdout, home,
       [unphied]