Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use spawn() instead of spawnSync() #93

Closed
yegor256 opened this issue Nov 7, 2022 · 2 comments · Fixed by #98
Closed

use spawn() instead of spawnSync() #93

yegor256 opened this issue Nov 7, 2022 · 2 comments · Fixed by #98
Assignees
Labels
enhancement New feature or request

Comments

@yegor256
Copy link
Member

yegor256 commented Nov 7, 2022

At the moment, we have this code in mvnw.js:

  const result = spawnSync(
    bin,
    process.platform == 'win32' ? params.map((p) => `"${p}"`) : params,
    {
      cwd: home,
      stdio: 'inherit',
      shell: shell(),
    }
  );

It runs a provided bin command and returns its exit code. While it runs, we have no control. I suggest to replace spawnSync with spawn and check the status of the running command asynchronously. While waiting for the command to finish we can list all files in the directory and print its total count. This printing will help the user who is waiting to get a better feeling about the process.

@yegor256
Copy link
Member Author

yegor256 commented Nov 7, 2022

@volodya-lombrozo can you help with this?

@volodya-lombrozo
Copy link
Member

@yegor256 I can try, just assign issue to me

@yegor256 yegor256 added the enhancement New feature or request label Nov 7, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Nov 30, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Dec 1, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Dec 1, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Dec 1, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Dec 2, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Dec 2, 2022
@rultor rultor closed this as completed in #98 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants