Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chained commands #97

Closed
volodya-lombrozo opened this issue Nov 21, 2022 · 2 comments · Fixed by #126
Closed

Chained commands #97

volodya-lombrozo opened this issue Nov 21, 2022 · 2 comments · Fixed by #126
Labels
bug Something isn't working

Comments

@volodya-lombrozo
Copy link
Member

When I run the next command it only cleans the directory:

eoc clean dataize app

Dataization doesn't happen. And I have to call eoc dataize app again. It would be useful to be able to state several eoc commands like clean and dataize in one line, as for me.

@yegor256 yegor256 added the bug Something isn't working label Nov 21, 2022
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Jan 27, 2023
@volodya-lombrozo
Copy link
Member Author

volodya-lombrozo commented Jan 30, 2023

@yegor256 It seems that we can't implement that issue in a way we wanted to do so. I've asked about the problem on SO and here is the answer from the main contributor of commander library:

Commander supports subcommands, but not multiple commands at once

Other opportunities which we can implement:

  1. We can use --clean option
  2. We can make clean command default for all other commands

What do you think?

@yegor256
Copy link
Member

@volodya-lombrozo the second option that you suggested is very expensive. We don't want to start from scratch every time. Instead, we want to build only the increment that was changed. The --clean option seems to be a better idea

volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Feb 3, 2023
feat(objectionary#97): add --clean option

feat(objectionary#97): reuse clear function in all commands

feat(objectionary#97): add test for --clean option for dataize command
volodya-lombrozo added a commit to volodya-lombrozo/eoc that referenced this issue Feb 3, 2023
feat(objectionary#97): add --clean option

feat(objectionary#97): reuse clear function in all commands

feat(objectionary#97): add test for --clean option for dataize command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants