Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#50): convert to phi and back #51

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Dec 8, 2023

Closes: #50


PR-Codex overview

This PR focuses on adding functionality to convert EO programs to φ-calculus expressions and vice versa.

Detailed summary

  • Added eo-maven-plugin dependency for conversion
  • Four stages of conversion: registration, parsing, optimization, and actual conversion
  • Added goals in build pipeline for conversion
  • .eo files are converted to .phi files and placed in phiOutputDir directory
  • Added goals in build pipeline for converting φ-calculus expressions back to EO
  • Result .eo files are placed in printOutputDir directory
  • Example of EO Fibonacci program in φ-calculus provided

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Dec 8, 2023

@maxonfjvipon one small typo. Maybe it's good to add spell checking to our blog, similar to how it's done in my blog: https://github.com/yegor256/blog/blob/master/Rakefile#L185-L233

@maxonfjvipon maxonfjvipon changed the title feat(#50): covert to phi and back feat(#50): convert to phi and back Dec 8, 2023
@maxonfjvipon
Copy link
Member Author

@yegor256 yeah, it would be nice. Please have a look one more time

@yegor256
Copy link
Member

yegor256 commented Dec 8, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 8, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8ed37a1 into objectionary:master Dec 8, 2023
1 check passed
@rultor
Copy link
Contributor

rultor commented Dec 8, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blog post about PhiMojo and UnphiMojo
3 participants