Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary propagation #2

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove unnecessary propagation #2

merged 1 commit into from
Aug 25, 2022

Conversation

Masynchin
Copy link
Contributor

No description provided.

@Masynchin
Copy link
Contributor Author

I am waiting for approval, so CI can test whether this changes are safe.

@Masynchin
Copy link
Contributor Author

I am waiting for approval, so CI can test whether this changes are safe.

@yegor256

@yegor256 yegor256 merged commit 2a8c3eb into objectionary:master Aug 25, 2022
@yegor256
Copy link
Member

@Masynchin thanks for the contribution! this repo is a very very early draft. it's better to wait until I release the first stable version. in the meantime, you can contribute to phie project, which is also in Rust

@Masynchin
Copy link
Contributor Author

Masynchin commented Aug 25, 2022

@yegor256 Is there anything to fix or implement in phie? I can clean up some code in terms of existing logic, but if you want me to do a larger refactor, I can take a deeper look at phi-calculus. I have some thoughts, for example, about replacing regexp-based parsing with some parser-combinators-based library. Should I create appropriate issue to discuss it?

@yegor256
Copy link
Member

@Masynchin I'm not an expert in Rust. I created phie as my first project. I assume that I've made many mistakes there. Would be great if you can fix them (if you are an expert in Rust) and clean up the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants