find() with a closure

[yegor256]

This is what I would like to be able to do with Sodg.find() function:

use sodg::Sodg;
let mut g = Sodg::empty();
g.add(0).unwrap();
g.add(1).unwrap();
g.bind(0, 1, "foo").unwrap();
let v = g.find(0, "bar", |v, a| "foo").unwrap();
assert_eq!(1, v);

The closure that I provided to find function expects two parameters: 1) the ID of the vertex where finding algorithm stopped because edge "foo" is absent (v=0), 2) the name of the edge not found (a="bar"). The closure returns an alternative name of the edge and the search algorithm continues from it.

[yegor256]

@UARTman can you please help?

[UARTman]

Sure. Let's check if I understand correctly what you want it to do.

It checks for "bar" in children, doesn't find it, then goes through the children, calling the closure on every one, until it finds "bar". Then it uses that edge and goes further.

[yegor256]

@UARTman not exactly. It checks for "bar" in children, doesn't find it. Then, it calls the closure giving it itself (0) and the name of the missing children ("bar"). The closure returns "foo". It finds "foo" in children and continues.

I made a mistake in the original description of the ticket. Now fixed.

[yegor256]

@UARTman let's make it even more convenient. Let the closure accept three params: vertex ID, the head of the label, and the tail of the label. Say, the label is "a/bc.de". Here "a" is the head, while "bc.de" is the tail. If the label is "foo" -- its tail is "" (empty string).

[yegor256]

@UARTman any progress?

[UARTman]

I have an implementation that seems to work in a separate function find_with_closure. Should I just replace find with the new function or leave find as-is?

After we figure out this, I'll have to improve a docstring a bit, and then it'll be ready for merge.

[yegor256]

@UARTman let's merge find_with_closure first

[yegor256]

@UARTman any good?

[UARTman]

I'll send a pull request tomorrow.

[yegor256]

@rultor release, tag is 0.0.12

[rultor]

@rultor release, tag is 0.0.12

@yegor256 OK, I will release it now. Please check the progress here

[rultor]

@rultor release, tag is 0.0.12

@yegor256 Done! FYI, the full log is here (took me 17min)