Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data must be immutable in a vertex #62

Open
yegor256 opened this issue Jan 9, 2023 · 3 comments
Open

data must be immutable in a vertex #62

yegor256 opened this issue Jan 9, 2023 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@yegor256
Copy link
Member

yegor256 commented Jan 9, 2023

At the moment it's possible to call put() multiple times at the same vertex. Also, it's possible to call data() even if put() was never called for a given vertex. Let's fix this by introducing the following rules:

  • Until put() is called for a vertex, all data() calls return Err
  • It's only possible to call put() once, the second call leads to Err
  • Calling put(Hex::empty()) makes the vertex "full" (see Sodg::full() #61)

It seems that we should introduce a new boolean flag for a Vertex.

@yegor256 yegor256 added enhancement New feature or request bug Something isn't working labels Jan 9, 2023
@yegor256
Copy link
Member Author

yegor256 commented Jan 9, 2023

@UARTman please, help here

@l3r8yJ
Copy link
Contributor

l3r8yJ commented Feb 16, 2023

@yegor256 is this one free?

@yegor256
Copy link
Member Author

@l3r8yJ yes, you can take it

@l3r8yJ l3r8yJ mentioned this issue Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants