Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sodg::full() #61

Closed
yegor256 opened this issue Jan 9, 2023 · 5 comments
Closed

Sodg::full() #61

yegor256 opened this issue Jan 9, 2023 · 5 comments
Assignees
@UARTman
Labels
enhancement New feature or request

Comments

@yegor256
Copy link
Member

yegor256 commented Jan 9, 2023 •
edited

Let's create a new function full() in the Sodg struct:

pub fn full(&self, v: u32) -> Result<bool>;

It should return FALSE if the data is not yet set. It should not affect the state of taken flag.
@yegor256 yegor256 added the enhancement New feature or request label Jan 9, 2023
@yegor256
Copy link
Member Author

yegor256 commented Jan 9, 2023

@UARTman can you please help?

@yegor256
Copy link
Member Author

yegor256 commented Jan 9, 2023

@UARTman ignore this one for now, I'm not sure we need it

@yegor256 yegor256 mentioned this issue Jan 9, 2023
Open
yegor256 added a commit that referenced this issue Jan 12, 2023
@yegor256
#61 full()
9413652
@yegor256
Copy link
Member Author

@rultor release, tag is 0.0.19

@rultor
Copy link
Contributor

rultor commented Jan 12, 2023

@rultor release, tag is 0.0.19

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jan 12, 2023

@rultor release, tag is 0.0.19

@yegor256 Done! FYI, the full log is here (took me 3min)

@l3r8yJ l3r8yJ mentioned this issue Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UARTman UARTman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yegor256 @rultor @UARTman