Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #23

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Add Docker support #23

merged 2 commits into from
Jan 21, 2020

Conversation

pataquets
Copy link
Contributor

@pataquets pataquets commented Dec 11, 2019

Add Dockerfile to enable image building. Useful for development and tests under Docker workflow.
Using the official Python image, :2 tag. More info at https://hub.docker.com/_/python/

Just adding files, setting working dir and running install.

Build:

$ docker build -t elasticstat .

Run:

$ docker run --rm -it elasticstat [options...]

FYI, there's a still quicker to test, already built image on my Docker Hub. Test it by running:

$ docker run --rm -it pataquets/elasticstat-src [options...]

Should stop by CTRL+C'ing it.
If no options given, assume --helpto avoid any error message.

Optional improvement to come (maybe in another issue):

  • Create an 'official', based on your repo, automated build at Docker Hub for the image: https://docs.docker.com/docker-hub/builds/ . Just requires a free Docker Hub account and a following a quick 'Create automated build' process. I'll be happy to help on it, if needed. Useful as an easy direct-from-source (branches and tags) distribution method and for having a 'daily' build from source on each commit.

@paulrossmeier
Copy link
Contributor

Hello pataquets,

I wanted to thank you for your contribution - we are reviewing and will update accordingly.

Paul Rossmeier

@paulrossmeier
Copy link
Contributor

I have tested this and works fine - I need to get a reviewer to approve the merge

Paul Rossmeier

Dockerfile Outdated Show resolved Hide resolved
@naemono naemono merged commit 23c9706 into objectrocket:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants