allow to define a custom default response encoder #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 81
💛 - Coveralls |
jfbus
reviewed
Oct 9, 2018
jfbus
reviewed
Oct 9, 2018
jfbus
suggested changes
Oct 9, 2018
http_test.go
Outdated
| }, | ||
| Body: ioutil.NopCloser(bytes.NewBuffer([]byte("OK:override"))), | ||
| }) | ||
| if !overrideCalled { |
There was a problem hiding this comment.
If override was called by the previous test but not this one, this does not fail...
There was a problem hiding this comment.
As long as you test the response body, is it really necessary to test overrideCalled ?
jfbus
reviewed
Oct 9, 2018
http_test.go
Outdated
| URL: &url.URL{ | ||
| Path: "/test/default", | ||
| }, | ||
| Body: ioutil.NopCloser(bytes.NewBuffer([]byte(`{}`))), |
There was a problem hiding this comment.
no body on GET requests => remove this line
jfbus
suggested changes
Oct 9, 2018
http_test.go
Outdated
| if rec.Code != 200 { | ||
| t.Errorf("default HTTP response status expected: %d", rec.Code) | ||
| } | ||
| body := string(rec.Body.Bytes()) |
http_test.go
Outdated
| "github.com/go-kit/kit/endpoint" | ||
| ) | ||
|
|
||
| type Response struct { |
jfbus
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default go-kit JSON encoder could be override in the configuration of kitty HTTP transport, so we don't pass the same encoder at each endpoint, but still be able to override it from the endpoint as option.