Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client that doesn't deal with HTTP Errors #16

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

JulienTant
Copy link
Contributor

In some case, you might want to decode the error message returned by an HTTP server. In the current implementation of the client, when a HTTP error is catch by the decoder, it skips the decoding and return directly the HTTPError. With this version, the client will have to deal with the HTTP Error while decoding.

@coveralls
Copy link

coveralls commented Oct 11, 2019

Pull Request Test Coverage Report for Build 118

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 78.996%

Totals Coverage Status
Change from base Build 109: -0.7%
Covered Lines: 850
Relevant Lines: 1076

💛 - Coveralls

@b-2-83 b-2-83 merged commit 07d95a0 into master Oct 11, 2019
@JulienTant JulienTant deleted the add-http-client-with-error branch October 11, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants