Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Version to BaseVersion #12

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Rename Version to BaseVersion #12

merged 2 commits into from
Jan 11, 2019

Conversation

jfbus
Copy link
Contributor

@jfbus jfbus commented Jan 11, 2019

As the RFC has renamed Version to BaseVersion, the corresponding field is being renamed.

@jfbus jfbus merged commit 07e3459 into master Jan 11, 2019
@jfbus jfbus deleted the bver branch January 11, 2019 14:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 40

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 93.529%
Changes Missing Coverage Covered Lines Changed/Added Lines %
senml.go 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
senml.go 1 96.04%
Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 159
Relevant Lines: 170
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 40

  • 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 93.529%
Changes Missing Coverage Covered Lines Changed/Added Lines %
senml.go 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
senml.go 1 96.04%
Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 159
Relevant Lines: 170
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfbus @coveralls