Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail.imap.peek #6

Merged
merged 2 commits into from Oct 23, 2020
Merged

Add mail.imap.peek #6

merged 2 commits into from Oct 23, 2020

Conversation

kiaruzza
Copy link
Contributor

Fix #5

@kiaruzza kiaruzza requested a review from igr as a code owner October 22, 2020 23:57
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #6 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #6      +/-   ##
============================================
- Coverage     66.11%   66.06%   -0.05%     
  Complexity      316      316              
============================================
  Files            26       26              
  Lines          1328     1332       +4     
  Branches        125      128       +3     
============================================
+ Hits            878      880       +2     
- Misses          377      378       +1     
- Partials         73       74       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/jodd/mail/MailServer.java 69.64% <ø> (ø) 3.00 <0.00> (ø)
src/main/java/jodd/mail/ImapServer.java 70.58% <100.00%> (+1.83%) 4.00 <0.00> (ø)
src/main/java/jodd/mail/RFC2822AddressParser.java 76.92% <0.00%> (-0.22%) 42.00% <0.00%> (ø%)
src/main/java/jodd/mail/SmtpSslServer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68df662...15bca1a. Read the comment docs.

@kiaruzza
Copy link
Contributor Author

@igr how can I resolve this?

@igr
Copy link
Member

igr commented Oct 23, 2020

Hey @kiaruzza what do you need to resolve? It looks fine, I will merge today :)

@kiaruzza
Copy link
Contributor Author

Hey @kiaruzza what do you need to resolve? It looks fine, I will merge today :)

Sorry, I was referring to project's code coverage. If it's ok, better this way. Tnx :)

@igr
Copy link
Member

igr commented Oct 23, 2020

Yeah, just ignore it, the delta is really low: (0.05) :)))

@igr igr merged commit 78f5ed0 into oblac:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unseen messages become seen
2 participants