Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for document.body.scrollHeight on IE11 #157

Merged
merged 2 commits into from
Nov 9, 2015
Merged

workaround for document.body.scrollHeight on IE11 #157

merged 2 commits into from
Nov 9, 2015

Conversation

jrr
Copy link
Contributor

@jrr jrr commented Nov 4, 2015

No description provided.

@jrr
Copy link
Contributor Author

jrr commented Nov 9, 2015

IE11 will return a zero document.body.scrollHeight under certain circumstances, which can break duScrollBottomSpy. Repro with http://embed.plnkr.co/xKx6ATH1jtBVr2FcOeNO/preview

@oblador
Copy link
Owner

oblador commented Nov 9, 2015

Thanks for the PR! Don't have IE11 to test with right now, but lgtm so I'll go ahead and merge.

oblador added a commit that referenced this pull request Nov 9, 2015
workaround for document.body.scrollHeight on IE11
@oblador oblador merged commit 8c74beb into oblador:master Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants