Support skip via story parameters #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techeverri
reviewed
Apr 3, 2020
| <Welcome showApp={linkTo('Button')} /> | ||
| )); | ||
| storiesOf('Welcome', module) | ||
| .lokiSkip('to Storybook', () => <Welcome showApp={linkTo('Button')} />) |
There was a problem hiding this comment.
So lokiSkip will continue to exist and behave like add?
There was a problem hiding this comment.
Yeah, i'll add warnings for now and remove it some time in the future.
techeverri
reviewed
Apr 3, 2020
| warnedSkipDeprecation = true; | ||
| console.warn( | ||
| '[DEPRECATED] `.add.skip(...)` is deprecated. Please use `.lokiSkip(...)` instead.' | ||
| '[DEPRECATED] `.add.skip(...)` and `.lokiSkip(...)` are deprecated. Please pass `{ loki: { skip: true } }` in the third parameter instead.' |
techeverri
approved these changes
Apr 3, 2020
techeverri
reviewed
Apr 8, 2020
|
Here too 😄 |
Closed
72636c
added a commit
to seek-oss/scoobie
that referenced
this pull request
Jul 14, 2020
The `lokiSkip` method is deprecated. oblador/loki#228
72636c
added a commit
to seek-oss/scoobie
that referenced
this pull request
Jul 14, 2020
The `lokiSkip` method is deprecated. oblador/loki#228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the configuration of skipping individual stories to the story
parameterfield, deprecating thelokiSkipmethod. Additionally it drops the deprecated use ofkind+storycombination and uses theidintroduced in SB 5.Fixes #176 #190 #198
This is a breaking change, dropping support for storybook prior to version 5.0 which was released about one year ago. It is probably possible to keep backwards support, but it would be a bit messy and would have to rely on heuristics.