Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http server for file references in chrome.app #472

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

gidztech
Copy link
Contributor

@gidztech gidztech commented Aug 4, 2023

The static file server was previously added to the Docker target (#461), but it also needed to be added to the app target (for when you need to run Loki without Docker, e.g. in CI). I have copied the relevant changes over and moved shared modules into core.

Fixes #471 and #465

@gidztech
Copy link
Contributor Author

gidztech commented Aug 4, 2023

@oblador Not sure about the unit test failing. It doesn't seem to be able to get a port in the lambda container.

@gidztech gidztech force-pushed the master branch 2 times, most recently from 17e22e1 to 016c31a Compare August 17, 2023 12:47
@gidztech
Copy link
Contributor Author

gidztech commented Aug 17, 2023

@oblador I tweaked solution to not use static file server with lambda renderer as I think there's some networking thing to solve. Rather than try to solve that now, I opted for fixing it it for chrome.app target to try and unblock everyone using that. That way there's no new breaking changes.

I think the Docker tests are a bit flaky. The same failure on the last master branch commit, so nothing introduced here. Not able to re-run them on the PR.

@qooban
Copy link
Contributor

qooban commented Aug 31, 2023

@gidztech Thanks for providing the fix. @oblador #465 is one of the blockers for us to upgrade to Storybook 7, so I'm interested in this PR to be merged and new version of Loki to be released. Let me know if I could help somehow in speeding up that process.

@TudorTacal
Copy link

Hi team, any progress on this? It'd be nice to use Loki with Storybook 7 without any of the issues. Thank you.

@oblador oblador merged commit 16b8181 into oblador:master Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook fonts still failing to load from within Docker as of version 0.32
4 participants