Make it possible to override isInteraction #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Mind adding it to thr readme too? |
|
Sure thing. Also fixed lint errors for real! |
oblador
approved these changes
Oct 23, 2019
|
When will it be published to npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to override isInteraction for the animation. As it is today non-looping (iterationCount <= 1) animatinos will always set isInteraction to true and looping animations will set it to false.
With this pull request that behaviour can be overriden by defining isInteraction as a prop on the component.
I needed this for a long running animation that shouldn't block interaction mananger. I also saw that someone else asked for the same feature a while ago (#241).