Added the urlTimeout property, to stop showing an activity indicator when the url is broken. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when this value is reached (for broken urls).
|
Doesn't React Native core already send an |
|
I don't know if it does, but I had spinners spinning (while trying to retrieve an image with a broken link) for at least 10 minutes...! |
|
Hmm, maybe that should be fixed in RN core instead? |
|
No idea, but until it does, this feature is a must have. We can't have an activity indicator running for ever.. |
…the uri found in the source when the urlTimeout ends.
…ispatch when the image has already succesfully loaded.
|
Whoaaa, this is what I wanted...any update on this? |
oblador
added a commit
that referenced
this pull request
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlTimeoutmilliseconds.